Adding aria-describedby attribute to target?

[GCheung55]

Should the aria-describedby attribute be ember-attacher's responsibility to add to the target?

[kybishop]

I realize that ember-tooltips does this, but my first instinct is that we should not follow suite.

I'm wary of adding an implicit side-effect that modifies something outside of our component.

Seems like we should avoid touching things outside the {{ember-attacher}} to avoid surprising people with a side effect they might not want.

Very open to discussion on this; I fully admit to not knowing too many details about aria support.

[kybishop]

Only an hour in and I've changed my mind on this. Seems like it is standard behavior across tooltip libs to modify the target. I think we should add aria-describedby by default, but have an option to exclude it for things like popovers.

[RobbieTheWagner]

@kybishop perhaps we should have two separate components for popover and tooltip, so we could exclude it by default? ember-tooltips has two components, so might not be terrible. Could also add classes by default then of ember-attacher-tooltip and ember-attacher-popover, based on which component you use.

[kybishop]

@rwwagner90 that sounds reasonable. We could make a mixin that does basically everything, then have a few additional functionalities in the specific components.

[GCheung55]

Just adding a bit more info, https://www.w3.org/TR/wai-aria-practices/#tooltip also mentions using aria-describedby.

[kybishop]

I have a gameplan for this, will hopefully have a custom tooltip component in the next few days.