Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isShown, showOn, and hideOn do not work together #25

Closed
RobbieTheWagner opened this issue Aug 18, 2017 · 2 comments
Closed

isShown, showOn, and hideOn do not work together #25

RobbieTheWagner opened this issue Aug 18, 2017 · 2 comments

Comments

@RobbieTheWagner
Copy link
Collaborator

If I use showOn='click' and hideOn='click', then passing isShown=false will not force it to close, however, if I set showOn='none' and hideOn='none' and try to use isShown it does toggle visibility, but then it is rendered in the wrong location, not tied to its parent.
@kybishop
Copy link
Collaborator

@rwwagner90 are you still experiencing this issue? I've patched up the tests and all looks well to me both there and in the dummy app.

@kybishop
Copy link
Collaborator

This should be fixed by #48. Feel free to re-open if you're still experiencing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kybishop @RobbieTheWagner