-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to add an offset/padding #107
Comments
Hey @luxferresum, I'll write something up for you soon, just a little swamped playing catch-up on work after a brutal week-long cold. |
Here's a brief summary of how the offset works: The attachment is actually two containers, an outer container for the positioning addon, ember-popper, and an inner container for the animations. The outer container is set up just like you'd expect, positioned right next to the target. It is the inner container that is implementing the offset. The default animations for ember-attacher do this with a CSS
|
I have documented this a little more thoroughly in the README when talking about how animations are implemented. Hopefully this clears up confusion over the perceived offset. |
On the demo site there is an offset between the tooltip and the target:
But when I tried to implement the tooltip I never get this offset:
So I think some documentation is missing here at least. Any help about this?
I've realized there is an undocumented
isOffset
feature in the code. Also the corresponding test usesmargin-bottom
, which works, but breaks when the popperflips
. What is the recommended way to do this, and can this please be documented somewhere?The text was updated successfully, but these errors were encountered: