Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion #88

Open
4 tasks done
sabirveli opened this issue Sep 24, 2021 · 2 comments · May be fixed by #90
Open
4 tasks done

Accordion #88

sabirveli opened this issue Sep 24, 2021 · 2 comments · May be fixed by #90
Assignees

Comments

@sabirveli
Copy link
Contributor

sabirveli commented Sep 24, 2021

  • style fixes
  • doc update
  • title click prop
  • review doc @soyef
@sabirveli sabirveli self-assigned this Sep 24, 2021
@sabirveli sabirveli linked a pull request Sep 27, 2021 that will close this issue
@sunnypol92
Copy link
Contributor

@soyef-bit have a look at the doc please

@sabirveli sabirveli assigned soyef-bit and unassigned sabirveli Sep 29, 2021
@soyef-bit
Copy link
Contributor

soyef-bit commented Sep 30, 2021

@sabirveli @sunnypol92

Accordion

  • ideally title property should be unique for each section. If possible to implement in code or slots, then property could be removed from the args table
  • when a new item is opened, accordion animation opens the new item first, then closes the old item. Since only one item can be open at a time, this is taking unnecessary space for a split second, sometime making part of the accordion to go outside the view. Ideally it should close the open item first, then open a new item.
  • generally jerky animations
  • may be allow an item to be expanded by clicking the + button in the title, even when title_click is false, too keep some differentiation between clicking the title vs clicking the "+" button
  • I changed the doc for event:change to Fires an event on any change initiated by the user. Curious if this event will be triggered if user collapsed the last remaining open item by clicking its title, resulting in all items to be collapsed. If not, the this doc is wrong
  • reminder: allow option of having more than one item open at the same time. modify change event to notify which item closed and which item opened when both happens at one click
  • going up on expand, ideally going down is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants