Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace action interface from maps to tuples #156

Closed
brennanjl opened this issue Aug 2, 2023 · 2 comments
Closed

Replace action interface from maps to tuples #156

brennanjl opened this issue Aug 2, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@brennanjl
Copy link
Collaborator

brennanjl commented Aug 2, 2023 •
edited
Loading

When executing actions, the user passes a map[string]any to the action (for batch inserts, this is []map[string]any). This is not necessary, and can be replaced with passing tuples of [][]any.

ENG-193
@brennanjl brennanjl added the enhancement New feature or request label Aug 2, 2023
@brennanjl brennanjl changed the title Replace action interface from maps to tuples [ENG-193] Replace action interface from maps to tuples Aug 2, 2023
@brennanjl brennanjl changed the title [ENG-193] Replace action interface from maps to tuples Replace action interface from maps to tuples Aug 2, 2023
@jchappelow
Copy link
Member

Resolved by https://github.com/kwilteam/kwil-db/pull/178/files#diff-4434a5f7ccb43b49577dfe31de4558befcba52931a54f2860451efee8763533e I believe

@Yaiba
Copy link
Contributor

Yaiba commented Aug 17, 2023

Resolved by https://github.com/kwilteam/kwil-db/pull/178/files#diff-4434a5f7ccb43b49577dfe31de4558befcba52931a54f2860451efee8763533e I believe

You're right . #178 should close this.

@Yaiba Yaiba closed this as completed Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Yaiba @brennanjl @jchappelow