From 0079d074995b04c001313dbfeaf37b9b7eef6132 Mon Sep 17 00:00:00 2001 From: brennan lamey Date: Thu, 5 Oct 2023 15:13:10 -0500 Subject: [PATCH] made gavins requested changes --- extensions/README.md | 2 +- pkg/auth/ed25519.go | 1 + pkg/auth/eth_personal_sign.go | 1 + pkg/auth/signer.go | 5 ----- 4 files changed, 3 insertions(+), 6 deletions(-) diff --git a/extensions/README.md b/extensions/README.md index f9582f607..1c8b21f8a 100644 --- a/extensions/README.md +++ b/extensions/README.md @@ -4,7 +4,7 @@ Extensions are compile-time loaded pieces of code that impact core `kwild` funct ## Interfaces and Drivers -Extensions can made by implementing a driver for one of many interfaces. These implementations should be registered using Go's `init()` function, which will register the driver when the package is loaded. This is conceptually similar to Go's `database/sql` package, where users can implement custom `database/sql/driver/Driver` implementations. +Extensions can be made by implementing a driver for one of many interfaces. These implementations should be registered using Go's `init()` function, which will register the driver when the package is loaded. This is conceptually similar to Go's `database/sql` package, where users can implement custom `database/sql/driver/Driver` implementations. ## Build Tags diff --git a/pkg/auth/ed25519.go b/pkg/auth/ed25519.go index 16d190e55..ccecc9924 100644 --- a/pkg/auth/ed25519.go +++ b/pkg/auth/ed25519.go @@ -20,6 +20,7 @@ func init() { // ed25519 constants const ( // using Ed25519Auth for the authenticator name + Ed25519Auth = "ed25519" // ed25519SignatureLength is the expected length of a signature ed25519SignatureLength = 64 diff --git a/pkg/auth/eth_personal_sign.go b/pkg/auth/eth_personal_sign.go index 9e607825c..a0e26b074 100644 --- a/pkg/auth/eth_personal_sign.go +++ b/pkg/auth/eth_personal_sign.go @@ -20,6 +20,7 @@ func init() { const ( // using EthPersonalSignAuth for the authenticator name + EthPersonalSignAuth = "secp256k1_ep" // ethPersonalSignSignatureLength is the expected length of a signature ethPersonalSignSignatureLength = 65 diff --git a/pkg/auth/signer.go b/pkg/auth/signer.go index 202272a4b..782d3581d 100644 --- a/pkg/auth/signer.go +++ b/pkg/auth/signer.go @@ -5,11 +5,6 @@ import ( "github.com/kwilteam/kwil-db/pkg/crypto" ) -const ( - EthPersonalSignAuth = "secp256k1_ep" - Ed25519Auth = "ed25519" -) - // Signature is a signature with a designated AuthType, which should // be used to determine how to verify the signature. // It seems a bit weird to have a field "Signature" inside a struct called "Signature",