[BLAZE-587] Replace spark<major><minor><patch> pattern with spark-<major><minor> for maven profile and shim name #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
force-pushed
the
BLAZE-587
branch
2 times, most recently
from
a041be0 to
883a486
Compare
…jor><minor> for maven profile and shim name
SteNicholas
force-pushed
the
BLAZE-587
branch
from
883a486 to
cef4833
Compare
richox
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #587.
Rationale for this change
spark<major><minor><patch>pattern is not suitable for maven profile and shim name. It's recommended to usespark-<major><minor>for Spark 3.x.What changes are included in this PR?
Replace
spark<major><minor><patch>pattern withspark-<major><minor>for maven profile and shim name.Are there any user-facing changes?
The maven profile and shim name use
spark-<major><minor>pattern.