-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the zstd codec for native spill #656
Comments
i suggest using a property other than |
and have you done some benchmark using zstd spilling? it will get worse performance than lz4/snappy, if i don't understand wrong. |
Another option is acceptable.
Haven't. I'm still reading this part code. |
And I think we still can reuse the IoCompressionReader/Writer . WDYT? @richox |
i'm afraid not, some spilled data is not in record batch format, for example AggExec spill row-based grouping keys, while IoCompressionWriter only accepts record batches. |
From my sight, the IoCompressionWriter will accept the simple bufs |
Is your feature request related to a problem? Please describe.
In current codebase, the lz4 codec is used in the spill. zstd should be supported.
Additional context
I will do this if no rejection from project owner.
The text was updated successfully, but these errors were encountered: