Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the zstd codec for native spill #656

Open
zuston opened this issue Nov 24, 2024 · 6 comments · May be fixed by #657
Open

Introduce the zstd codec for native spill #656

zuston opened this issue Nov 24, 2024 · 6 comments · May be fixed by #657

Comments

@zuston
Copy link
Contributor

zuston commented Nov 24, 2024

Is your feature request related to a problem? Please describe.

In current codebase, the lz4 codec is used in the spill. zstd should be supported.

Additional context

I will do this if no rejection from project owner.

@richox
Copy link
Collaborator

richox commented Nov 25, 2024

i suggest using a property other than spark.io.compression.codec since it is used in broadcast/shuffle where data goes through the network. for local spilling we would like to use a lightweight compression algorithm like lz4/snappy.
i prefer a property like blaze.spill.compression.codec, what do you think?

@richox
Copy link
Collaborator

richox commented Nov 25, 2024

and have you done some benchmark using zstd spilling? it will get worse performance than lz4/snappy, if i don't understand wrong.

@zuston
Copy link
Contributor Author

zuston commented Nov 25, 2024

i suggest using a property other than spark.io.compression.codec since it is used in broadcast/shuffle where data goes through the network. for local spilling we would like to use a lightweight compression algorithm like lz4/snappy. i prefer a property like blaze.spill.compression.codec, what do you think?

Another option is acceptable.

and have you done some benchmark using zstd spilling? it will get worse performance than lz4/snappy, if i don't understand wrong.

Haven't. I'm still reading this part code.

@zuston
Copy link
Contributor Author

zuston commented Nov 25, 2024

And I think we still can reuse the IoCompressionReader/Writer . WDYT? @richox

@richox
Copy link
Collaborator

richox commented Dec 3, 2024

And I think we still can reuse the IoCompressionReader/Writer . WDYT? @richox

i'm afraid not, some spilled data is not in record batch format, for example AggExec spill row-based grouping keys, while IoCompressionWriter only accepts record batches.

@zuston
Copy link
Contributor Author

zuston commented Dec 6, 2024

From my sight, the IoCompressionWriter will accept the simple bufs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants