Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

MEW supports TomoChain Mainnet #2170

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

thanhson1085
Copy link
Contributor

type: nodes.nodeTypes.TOMO,
eip155: true,
chainId: 89,
chainId: 88,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chainID is conflicting with another. Your chainID is listed as 889 in https://github.com/satoshilabs/slips/blob/master/slip-0044.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I know, slip-0044 is for registering HD path (m/44'/889'/0'/0)
I created the PR to slip44 (satoshilabs/slips#365) and mentioned the chainID 88.
chainId 88 is also fixed in our genesis block

@thanhson1085
Copy link
Contributor Author

This PR is very important with us. We already announced the mainnet launch.

I created the PR to slip44 (satoshilabs/slips#365) and mentioned the chainID 88.
chainId 88 is also fixed in our genesis block and not easy to change.

Please take a look @gamalielhere, thank you.

@Logle
Copy link

Logle commented Dec 10, 2018

We are not aware of the practice using coin type index for chain ID for replay protection https://github.com/ethereum/EIPs/blob/master/EIPS/eip-155.md There is no Ethereum fork with ChainID = 88. Please advise if we can use that.

@gamalielhere gamalielhere merged commit 9051f32 into MyEtherWallet:mercury Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants