Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples use deprecated winit functions #204

Open
2 tasks
apekros opened this issue Nov 18, 2024 · 1 comment
Open
2 tasks

Examples use deprecated winit functions #204

apekros opened this issue Nov 18, 2024 · 1 comment

Comments

@apekros
Copy link
Contributor

apekros commented Nov 18, 2024

Since the upgrade to winit 0.30:

  • EventLoop::run() is now deprecated and replaced with run_app
  • EventLoop::create_window() is now deprecated and replaced with ActiveEventLoop::create_window()

The examples should be refactored to replace the deprecated functions.

I should have included this in my last PR, happy to just pick this up and fix it, just wanted to track it :)

@kvark
Copy link
Owner

kvark commented Nov 20, 2024

Yes, it's pretty annoying even though it's harmless. Your help would be much welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants