From 20a4fdcb58de3718c9a3913e78ef3b9fab851a42 Mon Sep 17 00:00:00 2001 From: Rafael Matias Date: Fri, 1 Nov 2024 12:01:07 +0100 Subject: [PATCH 1/2] fix: make releases work again without v in tags --- .github/workflows/release-please.yml | 2 ++ .release-please-manifest.json | 8 -------- release-please-config.json | 10 ++++++++++ 3 files changed, 12 insertions(+), 8 deletions(-) create mode 100644 release-please-config.json diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index b11aade10a..be4b03dbb8 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -16,3 +16,5 @@ jobs: # https://github.com/kurtosis-tech/kurtosis/issues/688 token: "${{ secrets.RELEASER_TOKEN }}" release-type: simple + config-file: release-please-config.json + manifest-file: .release-please-manifest.json diff --git a/.release-please-manifest.json b/.release-please-manifest.json index f1c9a16b7b..4918b25eb7 100644 --- a/.release-please-manifest.json +++ b/.release-please-manifest.json @@ -1,11 +1,3 @@ { - "packages": { - ".": { - "package-name": "kurtosis", - "bump-minor-pre-major": false, - "bump-path-for-minor-pre-major": false, - "include-v-in-tag": false - } - }, ".": "1.4.1" } diff --git a/release-please-config.json b/release-please-config.json new file mode 100644 index 0000000000..5a1a3f6b2d --- /dev/null +++ b/release-please-config.json @@ -0,0 +1,10 @@ +{ + "packages": { + ".": { + "package-name": "kurtosis", + "bump-minor-pre-major": false, + "bump-path-for-minor-pre-major": false, + "include-v-in-tag": false + } + } +} From 55ac4a0eb28dba5783817588e8bca6ad4f25413b Mon Sep 17 00:00:00 2001 From: Rafael Matias Date: Fri, 1 Nov 2024 15:37:32 +0100 Subject: [PATCH 2/2] fix: wrong config structure for release-please --- .github/workflows/release-please.yml | 1 - release-please-config.json | 10 ++++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index be4b03dbb8..8223f18610 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -15,6 +15,5 @@ jobs: # can run on the PR created # https://github.com/kurtosis-tech/kurtosis/issues/688 token: "${{ secrets.RELEASER_TOKEN }}" - release-type: simple config-file: release-please-config.json manifest-file: .release-please-manifest.json diff --git a/release-please-config.json b/release-please-config.json index 5a1a3f6b2d..734635575d 100644 --- a/release-please-config.json +++ b/release-please-config.json @@ -1,10 +1,12 @@ { + "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json", + "release-type": "simple", + "bump-minor-pre-major": false, + "bump-patch-for-minor-pre-major": false, + "include-v-in-tag": false, "packages": { ".": { - "package-name": "kurtosis", - "bump-minor-pre-major": false, - "bump-path-for-minor-pre-major": false, - "include-v-in-tag": false + "package-name": "kurtosis" } } }