feat: change log retention period to one week #2403
Merged
+54
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentluce
approved these changes
Apr 25, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 1, 2024
🤖 I have created a release *beep* *boop* --- ## [0.89.2](0.89.1...0.89.2) (2024-05-01) ### Features * change log retention period to one week ([#2403](#2403)) ([3f68795](3f68795)) * public ports don't have to be same length as private ports ([#2416](#2416)) ([9b8b9e3](9b8b9e3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
This was referenced Jul 29, 2024
|
Would it be possible to make the log retention period configurable instead? 1w still seems excessive for some usecases. |
|
With the debug logs I have 150 Gb of logs after 1-2 days running 2 nodes |
|
Noted @KatyaRyazantseva thanks for commenting! and yep! @barnabasbusa I'll make it configurable for hourly and daily log retention and send you a PR! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
## Description Logs retention period was updated to 1 week in #2403. This PR updates the documentation. ## REMINDER: Tag Reviewers, so they get notified to review @tedim52 ## Is this change user facing? YES <!-- If yes, please add the "user facing" label to the PR --> <!-- If yes, don't forget to include docs changes where relevant --> ## References (if applicable) https://github.com/kurtosis-tech/kurtosis/blob/7562dcb4859524bfe2c80a4328945577736ed9a4/engine/server/engine/centralized_logs/client_implementations/persistent_volume/volume_consts/consts.go#L21 Co-authored-by: Tedi Mitiku <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Decreases log retention period to a week.
Is this change user facing?
YES