fix: treat size value as megabytes #2030
Merged
+12
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we actually use Gigabytes over megabytes? |
barnabasbusa
approved these changes
Jan 8, 2024
|
@barnabasbusa discussed with you, this fix is fine for now but i will support 5GB, 2.5TB or other values, please create a ticket! |
leoporoli
approved these changes
Jan 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
🤖 I have created a release *beep* *boop* --- ## [0.86.2](0.86.1...0.86.2) (2024-01-09) ### Bug Fixes * treat size value as megabytes ([#2030](#2030)) ([af687cb](af687cb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We expect(in DOCS) the user to enter value in megabytes but were never multiplying the value with the megaByteToByte multiplier