Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement minor emui feedback tweaks #1827

Merged
merged 9 commits into from
Nov 17, 2023

Conversation

Dartoxian
Copy link
Contributor

Description:

A selection of smaller feedback items from the postdevconnect burndown:

  • Fixed tab index onto the enclave configuration form to prevent default focus being on the close button
  • Fixed destroy enclaves dialog closing early when multiple enclaves were destroyed
  • Print the emui version on launch in the browser console
  • Tooltips on enclave status and service status
  • Updated file download names for artifacts and service arguments to include --
  • Dynamically size the log viewer based on the window size (all css, no resize listeners).

Screenshots

image
image
image
image
image

Is this change user facing?

YES

@Dartoxian Dartoxian requested a review from adschwartz November 17, 2023 13:51
@adschwartz adschwartz added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit 8161a34 Nov 17, 2023
13 checks passed
@adschwartz adschwartz deleted the bgazzard/minor-emui-feedback branch November 17, 2023 14:28
github-merge-queue bot pushed a commit that referenced this pull request Nov 17, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.85.31](0.85.30...0.85.31)
(2023-11-17)


### Bug Fixes

* implement minor emui feedback tweaks
([#1827](#1827))
([8161a34](8161a34))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants