Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename config.proto for better discoverability #1

Open
jpeach opened this issue Sep 3, 2021 · 3 comments
Open

Rename config.proto for better discoverability #1

jpeach opened this issue Sep 3, 2021 · 3 comments
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@jpeach
Copy link

jpeach commented Sep 3, 2021

In the Kuma repository, the import path for config.proto is simply:

import "config.proto";

This is very confusing because there's no obvious relationship between the doc option and a file named config.proto, and the Kuma repository already has 2 different config.proto files.

This would be much more obvious if we could make the import thus:

import "kumadoc/doc.proto";
@jpeach
Copy link
Author

jpeach commented Sep 3, 2021

ping @bartsmykla

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Nov 19, 2021
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@jpeach jpeach added triage/pending This issue will be looked at on the next triage meeting and removed triage/stale Inactive for some time. It will be triaged again labels Nov 22, 2021
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 23, 2021
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana added kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting triage/stale Inactive for some time. It will be triaged again labels Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

2 participants