Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kds): use deprecated method in otel #8366

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Nov 14, 2023

otherwise it panics in our deployment

xref: open-telemetry/opentelemetry-go-contrib#4576

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- not reported
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@slonka slonka requested a review from a team as a code owner November 14, 2023 14:42
@slonka slonka requested review from jakubdyszkiewicz and bartsmykla and removed request for a team November 14, 2023 14:42
@slonka slonka enabled auto-merge (squash) November 14, 2023 14:50
@slonka slonka changed the title chore(deps): try using deprecated version chore(deps): use deprecated method in otel Nov 14, 2023
@slonka slonka merged commit 04774ee into kumahq:release-2.5 Nov 14, 2023
10 checks passed
@lahabana lahabana changed the title chore(deps): use deprecated method in otel fix(kds): use deprecated method in otel Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants