Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(k8s): fix VIPs configmap entries with invalid keys for ExternalName services (backport of #8168) #8195

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix(k8s): fix VIPs configmap entries with invalid keys for ExternalName services (backport of #8168) #8195

merged 1 commit into from
Oct 31, 2023

Commits on Oct 31, 2023

  1. fix(k8s): fix VIPs configmap entries with invalid keys for ExternalNa… 

    …me services (#8168)

Services with the `ExternalName` type do not allow us to get an
IP address, so the generated VIPs config map contains entries with
invalid keys, such as `1:`. This was hard to debug because we were
getting an EOF error during unmarshalling of the VIPs config map.

This commit fixes the issue by ignoring services of that type with
appropriate log when it'll happen.

Signed-off-by: Bart Smykla <[email protected]>
    @bartsmykla @kumahq
    bartsmykla authored and kumahq[bot] committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    6b73319 View commit details
    Browse the repository at this point in the history