fix(MeshTrafficPermission): support permissive mtls #8171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
jakubdyszkiewicz
requested review from
michaelbeaumont and
lukidzi
and removed request for
a team
michaelbeaumont
approved these changes
Oct 30, 2023
kumahq bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
This was referenced Oct 30, 2023
kumahq bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
This was referenced Oct 30, 2023
kumahq bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
jakubdyszkiewicz
added a commit
that referenced
this pull request
Oct 30, 2023
… (#8176) Signed-off-by: Jakub Dyszkiewicz <[email protected]> Co-authored-by: Jakub Dyszkiewicz <[email protected]>
jakubdyszkiewicz
added a commit
that referenced
this pull request
Oct 30, 2023
… (#8175) Signed-off-by: Jakub Dyszkiewicz <[email protected]> Co-authored-by: Jakub Dyszkiewicz <[email protected]>
jakubdyszkiewicz
added a commit
that referenced
this pull request
Oct 30, 2023
… (#8178) Signed-off-by: Jakub Dyszkiewicz <[email protected]> Co-authored-by: Jakub Dyszkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
Fix #8152
I noticed that we put RBAC filter even for filterChains without mTLS on them.
This PR fixes this so we put RBAC filters only on listeners with Kuma's mTLS (by checking transport socket match).
This was also the case for TrafficPermission, not only for MeshTrafficPermission.
Why was it not caught by E2E test?
It was not a problem when you have "allow any to any" policy, because in this case even though we put RBAC filter it has principal "any" which matches any traffic in the end.
syscall.Mkfifohave equivalent implementation on the other OS --ci/labels to run additional/fewer testsUPGRADE.md? --