-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dp-token): allow validator to define keys not scoped to a mesh #8169
Merged
jakubdyszkiewicz
merged 4 commits into
kumahq:master
from
koyeb:multi-mesh-offline-dp-token
Oct 27, 2023
Merged
feat(dp-token): allow validator to define keys not scoped to a mesh #8169
jakubdyszkiewicz
merged 4 commits into
kumahq:master
from
koyeb:multi-mesh-offline-dp-token
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This permits dpServer.authn.dpPRoxy.dpToken.validator.publicKeys to omit the .mesh field. Keys without the .mesh field will be considered to verify the signature of dataplane tokens, no matter the mesh of the dataplane. Signed-off-by: nicoche <[email protected]>
nicoche
requested review from
michaelbeaumont and
lukidzi
and removed request for
a team
October 27, 2023 11:51
nicoche
changed the title
feat(dp-token): allow keys not scoped to a mesh
feat(dp-token): allow validator to define keys not scoped to a mesh
Oct 27, 2023
Nice! Could you also add E2E test for it?
This way we can validate this functionality and also check if we can combine meshed and not meshed keys. Let me know if you need help |
Great! Honestly, I did not know where to look for, regarding the tests. I'll add that |
nicoche
force-pushed
the
multi-mesh-offline-dp-token
branch
from
October 27, 2023 12:31
ed7c4e4
to
176c7ac
Compare
Signed-off-by: nicoche <[email protected]>
nicoche
force-pushed
the
multi-mesh-offline-dp-token
branch
from
October 27, 2023 13:11
6acf462
to
cf02961
Compare
Signed-off-by: nicoche <[email protected]>
Should be good now, the e2e tests pass locally 🙂 |
Signed-off-by: nicoche <[email protected]>
nicoche
force-pushed
the
multi-mesh-offline-dp-token
branch
from
October 27, 2023 14:03
6233700
to
aed9b21
Compare
jakubdyszkiewicz
approved these changes
Oct 27, 2023
nicoche
added a commit
to koyeb/kuma
that referenced
this pull request
Oct 28, 2023
…umahq#8169) This permits dpServer.authn.dpPRoxy.dpToken.validator.publicKeys to omit the .mesh field. Keys without the .mesh field will be considered to verify the signature of dataplane tokens, no matter the mesh of the dataplane. Signed-off-by: nicoche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This permits dpServer.authn.dpPRoxy.dpToken.validator.publicKeys to omit the .mesh field. Keys without the .mesh field will be considered to verify the signature of dataplane tokens, no matter the mesh of the dataplane.
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --