test(unit): fix flaky "should return error when admin address is not allowed" test #7933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <[email protected]>
lobkovilya
requested review from
jakubdyszkiewicz and
bartsmykla
and removed request for
a team
lobkovilya
changed the title
michaelbeaumont
approved these changes
Sep 29, 2023
lobkovilya
added a commit
that referenced
this pull request
Oct 3, 2023
…allowed" test (#7933) fix(kuma-cp): use SortedKeys function in error msg Signed-off-by: Ilya Lobkov <[email protected]>
lobkovilya
added a commit
that referenced
this pull request
Oct 3, 2023
…allowed" test (#7933) fix(kuma-cp): use SortedKeys function in error msg Signed-off-by: Ilya Lobkov <[email protected]>
lobkovilya
added a commit
that referenced
this pull request
Oct 3, 2023
…allowed" test (#7933) fix(kuma-cp): use SortedKeys function in error msg Signed-off-by: Ilya Lobkov <[email protected]>
lobkovilya
added a commit
that referenced
this pull request
Oct 3, 2023
…allowed" test (#7933) fix(kuma-cp): use SortedKeys function in error msg Signed-off-by: Ilya Lobkov <[email protected]>
michaelbeaumont
added a commit
that referenced
this pull request
Oct 5, 2023
…veness probes (backport of #7909) (#7928) * fix(kuma-cp): specifying IPv6 Envoy Admin address breaks readiness/liveness probes (#7909) Put a specified admin address to proxy metadata and use it when generating an admin cluster. * test(unit): fix flaky "should return error when admin address is not allowed" test (#7933) fix(kuma-cp): use SortedKeys function in error msg * make SortedKeys generic * chore(kuma-cp): improve error message for invalid admin addresses (#7934) * update golden files Signed-off-by: Ilya Lobkov <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Ilya Lobkov <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
michaelbeaumont
added a commit
that referenced
this pull request
Oct 5, 2023
…veness probes (backport of #7909) (#7926) * fix(kuma-cp): specifying IPv6 Envoy Admin address breaks readiness/liveness probes (#7909) Put a specified admin address to proxy metadata and use it when generating an admin cluster. * test(unit): fix flaky "should return error when admin address is not allowed" test (#7933) fix(kuma-cp): use SortedKeys function in error msg * make SortedKeys generic * chore(kuma-cp): improve error message for invalid admin addresses (#7934) * update golden files Signed-off-by: Ilya Lobkov <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Ilya Lobkov <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a flaky test in #7909, this is a fix
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?