Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): jitter zone insights upsert #7925

Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

  • Use upsert settings once again (it was used at some point and then dropped?). This way we can customize those values without releasing new version
  • Add jitter for storing envoy streams
  • Add jitter to upserts
  • Change default values to 200ms, max 10 retries and 30% jitter.

Fix ##7921

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner September 29, 2023 13:54
@jakubdyszkiewicz jakubdyszkiewicz requested review from lobkovilya and lukidzi and removed request for a team September 29, 2023 13:54
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Random question not directly related to this:

Why do we need to keep a globalInstanceId per EnvoyStream type? I thought there was a single KDS connection per Zone no?

Answering myself: I guess that's not true. Each Envoy Admin is a different stream so it's possible they'd end up on different connections and therefore LoadBalanced to different GCP instance

Correct?

@jakubdyszkiewicz
Copy link
Contributor Author

Correct.

@jakubdyszkiewicz jakubdyszkiewicz merged commit aa2d3c5 into kumahq:master Sep 29, 2023
5 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/jitter-zone-insights branch September 29, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants