-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): add possibility to run universal zone cp on kubernetes #7924
feat(helm): add possibility to run universal zone cp on kubernetes #7924
Conversation
Fixes: kumahq#7129 Signed-off-by: Marcin Skalski <[email protected]>
Fixes: kumahq#7129 Signed-off-by: Marcin Skalski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can you also make sure that we don't run HELM webhook for both global and zone universal. Thsoe hook patches namespace and manages CRD which is redundant
@jakubdyszkiewicz isn't this achieved by running helm with |
It's not. Even with |
Fixes: kumahq#7129 Signed-off-by: Marcin Skalski <[email protected]>
ok, checked and added missing |
Fixes: #7129
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?