Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kumactl): add --mesh parameter to inspect <policy> #7696

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix(kumactl): add --mesh parameter to inspect <policy> #7696

merged 1 commit into from
Sep 7, 2023

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Sep 7, 2023

This was missing up until now

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana lahabana requested a review from a team as a code owner September 7, 2023 08:13
@lahabana lahabana requested review from Automaat and bartsmykla and removed request for a team September 7, 2023 08:13
@lahabana lahabana enabled auto-merge (squash) September 7, 2023 08:16
@lahabana
fix(kumactl): add --mesh parameter to inspect <policy>
a1e0e86 
This was missing up until now

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana merged commit 5141208 into kumahq:master Sep 7, 2023
5 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023 •
edited
Loading

backporting to release-2.2 with action

backporting to release-2.0 with action
backporting to release-2.4 with action
backporting to release-2.3 with action
backporting to release-2.1 with action

@kumahq kumahq bot mentioned this pull request Sep 7, 2023
Closed
kumahq bot pushed a commit that referenced this pull request Sep 7, 2023
@lahabana @kumahq
fix(kumactl): add --mesh parameter to inspect <policy> (#7696)
b917153 
This was missing up until now

Signed-off-by: Charly Molter <[email protected]>
@kumahq kumahq bot mentioned this pull request Sep 7, 2023
Closed
kumahq bot pushed a commit that referenced this pull request Sep 7, 2023
@lahabana @kumahq
fix(kumactl): add --mesh parameter to inspect <policy> (#7696)
782b66f 
This was missing up until now

Signed-off-by: Charly Molter <[email protected]>
This was referenced Sep 7, 2023
Merged
Closed
kumahq bot pushed a commit that referenced this pull request Sep 7, 2023
@lahabana @kumahq
fix(kumactl): add --mesh parameter to inspect <policy> (#7696)
8315b51 
This was missing up until now

Signed-off-by: Charly Molter <[email protected]>
kumahq bot pushed a commit that referenced this pull request Sep 7, 2023
@lahabana @kumahq
fix(kumactl): add --mesh parameter to inspect <policy> (#7696)
2fec804 
This was missing up until now

Signed-off-by: Charly Molter <[email protected]>
@kumahq kumahq bot mentioned this pull request Sep 7, 2023
Closed
kumahq bot pushed a commit that referenced this pull request Sep 7, 2023
@lahabana @kumahq
fix(kumactl): add --mesh parameter to inspect <policy> (#7696)
076f973 
This was missing up until now

Signed-off-by: Charly Molter <[email protected]>
jakubdyszkiewicz pushed a commit that referenced this pull request Sep 7, 2023
@kumahq @lahabana
fix(kumactl): add --mesh parameter to inspect <policy> (backport of
ecac076 
#7696) (#7703)

Signed-off-by: Charly Molter <[email protected]>
Co-authored-by: Charly Molter <[email protected]>
@lahabana lahabana mentioned this pull request Sep 11, 2023
Closed
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2023
Merged
@lahabana lahabana deleted the fixInspectWithMesh branch March 29, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

@bartsmykla bartsmykla Awaiting requested review from bartsmykla bartsmykla is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahabana @jakubdyszkiewicz