Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): use bitnami/kubectl image for helm hooks #7656

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Sep 6, 2023

Fix #6326

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana lahabana requested a review from a team as a code owner September 6, 2023 07:20
@lahabana lahabana requested review from Automaat and bartsmykla and removed request for a team September 6, 2023 07:20
@lahabana
Copy link
Contributor Author

lahabana commented Sep 6, 2023

I think one inconvenient of this is that dependabot won't catch it. I think we need to inline the 3 parts to do this.

@bartsmykla
Copy link
Contributor

@lahabana what do you mean by:

I think we need to inline the 3 parts to do this.

Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove tools/kubectl then, right?

@lahabana
Copy link
Contributor Author

lahabana commented Sep 7, 2023

I think we can remove tools/kubectl then, right?

Yes and just did it

@bartsmykla bartsmykla added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Sep 7, 2023
@lahabana lahabana force-pushed the fix6326 branch 2 times, most recently from 3c6d644 to fe80cf8 Compare September 12, 2023 08:45
also remove tools/kubectl

Fix kumahq#6326

Signed-off-by: Charly Molter <[email protected]>
@lahabana
Copy link
Contributor Author

Finally works @slonka

@lahabana lahabana merged commit ace9c13 into kumahq:master Sep 12, 2023
5 checks passed
@lahabana lahabana changed the title fix(install): use bitnami/kubectl image for helm hooks fix(k8s): use bitnami/kubectl image for helm hooks Nov 3, 2023
@lahabana lahabana changed the title fix(k8s): use bitnami/kubectl image for helm hooks fix(helm): use bitnami/kubectl image for helm hooks Nov 3, 2023
@lahabana lahabana deleted the fix6326 branch March 29, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review which kubectl image to use in Helm hooks
4 participants