Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obs): add traceId in error messages #7329

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Jul 24, 2023

Fix #7296

Changelog: feat(observability): add traceId in error messages

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana lahabana requested a review from a team as a code owner July 24, 2023 12:18
@lahabana lahabana requested review from michaelbeaumont and jakubdyszkiewicz and removed request for a team July 24, 2023 12:18
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep in mind that this will break KM upgrade

@lahabana lahabana merged commit 4d238e1 into kumahq:master Jul 26, 2023
@lahabana lahabana deleted the traceInErrors branch March 29, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add traceId to errors in the API
2 participants