fix(kuma-cp): handle external services with permissive mtls #7179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
jakubdyszkiewicz
requested review from
bartsmykla and
lobkovilya
and removed request for
a team
bartsmykla
approved these changes
Jul 6, 2023
kumahq bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
This was referenced Jul 6, 2023
kumahq bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
jakubdyszkiewicz
added a commit
that referenced
this pull request
Jul 6, 2023
… of #7179) (#7187) * fix(kuma-cp): handle external services with permissive mtls (#7179) Signed-off-by: Jakub Dyszkiewicz <[email protected]> * chore: resolve conflict Signed-off-by: Jakub Dyszkiewicz <[email protected]> --------- Signed-off-by: Jakub Dyszkiewicz <[email protected]> Co-authored-by: Jakub Dyszkiewicz <[email protected]>
jakubdyszkiewicz
added a commit
that referenced
this pull request
Jul 6, 2023
… of #7179) (#7185) * fix(kuma-cp): handle external services with permissive mtls (#7179) Signed-off-by: Jakub Dyszkiewicz <[email protected]> * chore: resolve conflict Signed-off-by: Jakub Dyszkiewicz <[email protected]> --------- Signed-off-by: Jakub Dyszkiewicz <[email protected]> Co-authored-by: Jakub Dyszkiewicz <[email protected]>
jakubdyszkiewicz
added a commit
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
jakubdyszkiewicz
added a commit
that referenced
this pull request
Jul 7, 2023
… of #7179) (#7188) * fix(kuma-cp): handle external services with permissive mtls (#7179) Signed-off-by: Jakub Dyszkiewicz <[email protected]> * chore: resolve conflict Signed-off-by: Jakub Dyszkiewicz <[email protected]> --------- Signed-off-by: Jakub Dyszkiewicz <[email protected]> Co-authored-by: Jakub Dyszkiewicz <[email protected]>
jakubdyszkiewicz
added a commit
that referenced
this pull request
Jul 7, 2023
… of #7179) (#7186) * fix(kuma-cp): handle external services with permissive mtls (#7179) Signed-off-by: Jakub Dyszkiewicz <[email protected]> * chore: resolve conflict Signed-off-by: Jakub Dyszkiewicz <[email protected]> --------- Signed-off-by: Jakub Dyszkiewicz <[email protected]> Co-authored-by: Jakub Dyszkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
While technically it's not an issue on master I want to have test/code parity between master an release-2.3 branch.
On the release branch we have
.Dataplanes.Totalwhich we don't fill anymore, therefore we had to switch to Offline + Online.On the release branch Service Insight for some reason increment number of Total DP, but does not increment Offline nor Offline so we end up with
falseoninsight.IssuedBackends[backend.Name] == insight.Dataplanes.Totalcondition.Fix #7140
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?