Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): add tracing to KDS server #7160

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jul 4, 2023

Gives traces like the following:

Span #3
    Trace ID       : a8ec507e1548af1438b9f859da994763
    Parent ID      :
    ID             : b5183f331989f5a3
    Name           : kuma.mesh.v1alpha1.GlobalKDSService/StreamClusters
    Kind           : SPAN_KIND_SERVER
    Start time     : 2023-07-04 08:28:43.868995353 +0000 UTC
    End time       : 2023-07-04 08:42:12.451383472 +0000 UTC
    Status code    : STATUS_CODE_UNSET
    Status message :
Attributes:
     -> rpc.system: STRING(grpc)
     -> rpc.service: STRING(kuma.mesh.v1alpha1.GlobalKDSService)
     -> rpc.method: STRING(StreamClusters)
     -> net.sock.peer.addr: STRING(127.0.0.1)
     -> net.sock.peer.port: INT(48400)
     -> rpc.grpc.status_code: INT(1)

We'll probably have to experiment with these and see how useful they are and certainly add our own traces.

Checklist prior to review

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner July 4, 2023 08:45
@michaelbeaumont michaelbeaumont requested review from slonka and bartsmykla and removed request for a team July 4, 2023 08:45
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) July 4, 2023 08:46
@michaelbeaumont michaelbeaumont merged commit 66bd184 into kumahq:master Jul 4, 2023
@michaelbeaumont michaelbeaumont deleted the feat/tracing-kds branch July 4, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants