Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kuma-cp/kds): remove unnecessary function nesting for mapper #7018

Conversation

bartsmykla
Copy link
Contributor

@bartsmykla bartsmykla commented Jun 14, 2023

Remove function nesting for MapZoneTokenSigningKeyGlobalToPublicKey resource mapper as we were not using any of the provided arguments.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
    • No relevant issue
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • It won't as it doesn't change the functionality
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • No new tests, as this is just pure, small refactor, without changes in functionality
  • Do you need to update UPGRADE.md?
    • There is no need
  • Does it need to be backported according to the backporting policy?
    • There is no need
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: refactor(kds): remove unnecessary function nesting for MapZoneTokenSigningKeyGlobalToPublicKey resource mapper in kds context

Remove function nesting for `MapZoneTokenSigningKeyGlobalToPublicKey`
resource mapper as we were not using any of the provided arguments.

Signed-off-by: Bart Smykla <[email protected]>
@bartsmykla bartsmykla requested review from a team, slonka and jakubdyszkiewicz and removed request for a team June 14, 2023 03:29
@bartsmykla bartsmykla enabled auto-merge (squash) June 14, 2023 03:30
@bartsmykla bartsmykla merged commit a5e4f74 into kumahq:master Jun 14, 2023
@bartsmykla bartsmykla deleted the refactor/remove-wrapping-function-for-kds-context-mapper branch June 14, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants