test(e2e): fix helm upgrade test #6422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
jakubdyszkiewicz
added
the
ci/run-full-matrix
jakubdyszkiewicz
requested review from
a team,
slonka and
lukidzi
and removed request for
a team
lukidzi
approved these changes
Mar 31, 2023
|
@Mergifyio backport release-2.1 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 31, 2023
Signed-off-by: Jakub Dyszkiewicz <[email protected]> (cherry picked from commit 7c834a9)
mergify bot
added a commit
that referenced
this pull request
Mar 31, 2023
test(e2e): fix helm upgrade test (#6422) Signed-off-by: Jakub Dyszkiewicz <[email protected]> (cherry picked from commit 7c834a9) Co-authored-by: Jakub Dyszkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before my recent PR #6403 Helm Upgrade test did not even upgrade Kuma. It was executing Upgrade on the same Helm Kuma version.
Helm opts are stored in the ControlPlane object, therefore there are carried to Upgrade command. The problem was that the first install was calling
WithoutHelmOpt("global.image.tag")so that it disable default override ofglobal.image.taghttps://github.com/kumahq/kuma/blob/master/test/framework/k8s_cluster.go#L409 . However, it was carried toUpgrade()call. Therefore it was using the default app version from helm which is https://github.com/kumahq/kuma/blob/master/deployments/charts/kuma/Chart.yaml#L6This worked on my machine, because as I develop I had images with
0.0.0-preview.vlocal-buildtag locally.I also removed
WithHelmOpt("global.image.registry", Config.KumaImageRegistry)since it's redundant. There is already such default https://github.com/kumahq/kuma/blob/master/test/framework/k8s_cluster.go#L407Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?