fix(helm): upgrade CRDs instead of installing missing CRDs #6403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6201
Helm by default does not manage CRDs aside from installing them on the first Helm install.
That's why a long time ago we created a Helm pre-upgrade job that installs missing CRDs.
This solution worked so far because CRDs for the old policies did not have "content" in them.
With new policies, the CRDs have a definition of all the fields. In Kuma 2.1.0 we changed an enum in
MeshTrafficPermission
fromALLOW
toAllow
.However, our job did not upgrade CRDs it only installed them if they were missing.
This PR changes the job to reapply CRDs and not only create them.
install-missing-crds
toinstall-crds
, to avoid confusion.--only-missing
arg to reapply all crds--no-config
because the job was failing withError: Failed to create a directory "/home/nonroot/.kumactl": mkdir /home/nonroot/.kumactl: read-only file system
set -e
to scripts because the job was silently failing.WithHelmChartPath
inUpgrade
in E2E. Without it, we didn't even upgrade, because of the initialWithHelmChartPath(Config.HelmChartName)
opt-in installChecklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?