Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): add appProtocol to services we create #6157

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

lahabana
Copy link
Contributor

This is useful as some Kubernetes tools rely on this

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

This is useful as some Kubernetes tools rely on this

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana requested review from a team, Automaat and bartsmykla and removed request for a team February 28, 2023 09:26
@lahabana lahabana requested review from slonka and jakubdyszkiewicz and removed request for Automaat and bartsmykla February 28, 2023 09:27
@lahabana lahabana merged commit c332dbf into kumahq:master Feb 28, 2023
@lahabana lahabana deleted the appProtocol branch May 2, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants