feat(helm): use object instead of list for plugins.policies #5735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbeaumont
requested review from
a team,
slonka,
lobkovilya and
Automaat
and removed request for
a team
This allows it to be 'appended' to by other charts. Signed-off-by: Mike Beaumont <[email protected]>
michaelbeaumont
force-pushed
the
feat/helm_use_objects_plugins_policies
branch
from
092a04a
to
6376187
Compare
Please add it there. If we know of any charts (other then ours) that depend on our charts let's also reach out to the maintainers. |
|
I think the CI check failed because of #5680, merged master. Side note: do we need e2e tests for this (might be worth adding a label) since helm chart check is in GH Action? |
Was this ever released already? I don't think so so it's fine to do a breaking change |
Unfortunately it's in |
…ts_plugins_policies
jakubdyszkiewicz
approved these changes
Jan 18, 2023
Automaat
approved these changes
Jan 18, 2023
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows it to be 'appended' to by other charts. This is technically a breaking change but we can include this in
UPGRADE.md.Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?