Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kumactl): set klog to avoid logs from k8s #5590

Merged
merged 1 commit into from
Jan 6, 2023
Merged

fix(kumactl): set klog to avoid logs from k8s #5590

merged 1 commit into from
Jan 6, 2023

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Jan 6, 2023

Logs from klog would go to stdout which was ruining the output of commands like install-control-plane

Fix #5554

Signed-off-by: Charly Molter [email protected]

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana
fix(kumactl): set klog to avoid logs from k8s
94a5b59 
Logs from klog would go to stdout which was ruining the output
of commands like install-control-plane

Fix kumahq#5554

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana requested review from a team, michaelbeaumont and lukidzi and removed request for a team January 6, 2023 13:51
@lahabana lahabana enabled auto-merge (squash) January 6, 2023 17:19
@lahabana lahabana merged commit cb4b047 into kumahq:master Jan 6, 2023
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
@lahabana lahabana deleted the fix5554 branch May 2, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@lukidzi lukidzi Awaiting requested review from lukidzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

install control-plane on GCP outputs warning to stdout
2 participants
@lahabana @michaelbeaumont