Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bootstrap): improve validator policy bootstrap #5014

Merged
merged 2 commits into from
Sep 20, 2022
Merged

chore(bootstrap): improve validator policy bootstrap #5014

merged 2 commits into from
Sep 20, 2022

Conversation

lahabana
Copy link
Contributor

  • Use validators.ValidationError{} more nicely to avoid passing parameters
  • Update bootstrap template to split validation in 3 methods
  • Update already generated policies to this new pattern

Fix #5005

Signed-off-by: Charly Molter [email protected]

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here?

@lahabana
chore(bootstrap): improve validator policy bootstrap
21af312 
- Use validators.ValidationError{} more nicely to avoid passing parameters
- Update bootstrap template to split validation in 3 methods
- Update already generated policies to this new pattern

Fix kumahq#5005

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana requested a review from a team as a code owner September 15, 2022 16:39
@lahabana
Copy link
Contributor Author

@michaelbeaumont you should get that in before working on MeshTrace as it improves the bootstrapped validator

@lahabana lahabana enabled auto-merge (squash) September 20, 2022 09:22
@lahabana lahabana merged commit b45096d into kumahq:master Sep 20, 2022
@lahabana lahabana deleted the fix5005 branch March 29, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobkovilya lobkovilya lobkovilya approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Policy generator to generate validate() with sub-functions
3 participants
@lahabana @michaelbeaumont @lobkovilya