Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kumacp): mesh access log - proto + validation #4998

Merged
merged 27 commits into from
Sep 15, 2022

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Sep 13, 2022

Part of #4979

Checklist prior to review

Changelog: feat(kumacp) new mesh access log policy

  • Link to docs PR or issue -- this is not implem yet so docs pr will be in that PR
  • Link to UI issue or PR -- not a UI issue
  • Is the issue worked on linked? -- yes
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) -- yes
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS -- yes
  • Unit Tests -- yes
  • E2E Tests -- not yet, not implem
  • Manual Universal Tests -- not yet
  • Manual Kubernetes Tests -- not yet
  • Do you need to update UPGRADE.md? -- nope
  • Does it need to be backported according to the [backporting policy] (../blob/master/CONTRIBUTING.md#backporting)? -- no
  • Do you need to explicitly set a > Changelog: entry here?

Changelog: feat(policy): Add MeshAccessLog policy

@slonka slonka changed the title feat(kumacp) mesh access log implementation feat(kumacp) mesh access log - proto + validation Sep 13, 2022
mk/generate.mk Show resolved Hide resolved
@lahabana
Copy link
Contributor

I might have not socialized enough that we shouldn't spend time implementing kumactl for new policies. We'll do a separate task to make these not a bunch of copy paste.

@slonka
Copy link
Contributor Author

slonka commented Sep 13, 2022

I might have not socialized enough that we shouldn't spend time implementing kumactl for new policies. We'll do a separate task to make these not a bunch of copy paste.

@lahabana - I did not manually implement kumactl for this. I've just run make check and make test UPDATE_GOLDEN_FILES=true and that's what got generated. Otherwise those targets failed. The only files I touched manually are marked with my comments above.

@lahabana
Copy link
Contributor

Ha cool :)

@slonka
Copy link
Contributor Author

slonka commented Sep 13, 2022

Should I change skip_registration to true?

@slonka
Copy link
Contributor Author

slonka commented Sep 13, 2022

I've changed it to true since it made the CI pass.

@slonka slonka marked this pull request as ready for review September 13, 2022 13:47
@slonka slonka requested a review from a team as a code owner September 13, 2022 13:47
@slonka slonka changed the title feat(kumacp) mesh access log - proto + validation feat(kumacp): mesh access log - proto + validation Sep 13, 2022
Co-authored-by: Charly Molter <[email protected]>
Signed-off-by: Krzysztof Słonka <[email protected]>
@slonka
Copy link
Contributor Author

slonka commented Sep 14, 2022

Should I change skip_registration to true?

@lobkovilya what are the implications of skip_registration set to true and do you know why it makes the CI crash if it's set to false?

@slonka
Copy link
Contributor Author

slonka commented Sep 14, 2022

Be aware of the fact that I removed reference since we agreed that for the first iteration we will not support this. This commit can be reverted when we go back to implementing it.

@slonka slonka mentioned this pull request Sep 15, 2022
1 task
@slonka slonka merged commit 8b24b44 into kumahq:master Sep 15, 2022
@slonka slonka deleted the feat/mesh-access-log-implem branch September 15, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants