Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp): return content type of inspect endpoints #4965

Merged
merged 1 commit into from
Sep 5, 2022
Merged

fix(kuma-cp): return content type of inspect endpoints #4965

merged 1 commit into from
Sep 5, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

content-type of XDS inspect endpoints was missing which caused an unreadable GUI panel.

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests -- no
  • Manual Universal Tests --
  • Manual Kubernetes Tests -- no
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here? no because we did not release yet

@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner September 5, 2022 09:43
@jakubdyszkiewicz jakubdyszkiewicz merged commit 14a3c1e into kumahq:master Sep 5, 2022
@jakubdyszkiewicz jakubdyszkiewicz deleted the fix/content-type-xds branch September 5, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubdyszkiewicz @michaelbeaumont