Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch merbridge image registry to upstream #4838

Merged

Conversation

bartsmykla
Copy link
Contributor

@bartsmykla bartsmykla commented Aug 17, 2022

As merbridge was released with support of Kuma in its CNI plugin
we can switch to use upstream image instead our own

Checklist prior to review

  • Link to docs PR or issue -- just replacing the image to the upstream one
  • Link to UI issue or PR -- just replacing the image to the upstream one
  • Is the issue worked on linked? -- just replacing the image to the upstream one
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) -- just replacing the image to the upstream one
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS -- just replacing the image to the upstream one
  • Unit Tests -- just replacing the image to the upstream one
  • E2E Tests -- just replacing the image to the upstream one
  • Manual Universal Tests -- just replacing the image to the upstream one
  • Manual Kubernetes Tests -- just replacing the image to the upstream one
  • Do you need to update UPGRADE.md? -- just replacing the image to the upstream one
  • Does it need to be backported according to the backporting policy? -- just replacing the image to the upstream one

Changelog: chore(helm): switch merbridge image registry to upstream

As merbridge was released with support of Kuma in its CNI plugin
we can switch to use upstream image instead our own

Signed-off-by: Bart Smykla <[email protected]>
@bartsmykla bartsmykla requested a review from a team as a code owner August 17, 2022 04:25
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #4838 (d619c22) into master (9985228) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4838   +/-   ##
=======================================
  Coverage   46.46%   46.47%           
=======================================
  Files         690      690           
  Lines       47069    47069           
=======================================
+ Hits        21872    21873    +1     
+ Misses      23272    23271    -1     
  Partials     1925     1925           
Impacted Files Coverage Δ
pkg/xds/generator/direct_access_proxy_generator.go 90.90% <0.00%> (+1.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bartsmykla bartsmykla merged commit 79a13d5 into kumahq:master Aug 17, 2022
@bartsmykla bartsmykla deleted the chore/switch-merbridge-image-registry branch August 17, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants