Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatewayapi): ListenerReason for unresolved certificate refs, enable ReferenceGrant conformance tests #4806

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

michaelbeaumont
Copy link
Contributor

Runs more conformance tests

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? -- Gateway API v0.5.0 conformance #4597
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --

…fs, enable ReferenceGrant conformance tests

Signed-off-by: Mike Beaumont <[email protected]>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner August 11, 2022 17:45
@codecov-commenter
Copy link

Codecov Report

Merging #4806 (d18f89f) into master (308f420) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4806      +/-   ##
==========================================
- Coverage   46.46%   46.45%   -0.01%     
==========================================
  Files         690      690              
  Lines       47115    47115              
==========================================
- Hits        21891    21888       -3     
- Misses      23298    23299       +1     
- Partials     1926     1928       +2     
Impacted Files Coverage Δ
...e/k8s/controllers/gatewayapi/gateway_conversion.go 33.17% <0.00%> (ø)
pkg/xds/cache/once/cache.go 82.05% <0.00%> (-12.83%) ⬇️
pkg/xds/cache/once/once.go 95.00% <0.00%> (-5.00%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 90.90% <0.00%> (+1.13%) ⬆️
pkg/core/resources/manager/cache.go 88.31% <0.00%> (+2.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@michaelbeaumont michaelbeaumont changed the title fix(gatewayapi): correct ListenerReason for unresolved certificate refs, enable ReferenceGrant conformance tests fix(gatewayapi): ListenerReason for unresolved certificate refs, enable ReferenceGrant conformance tests Aug 11, 2022
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) August 11, 2022 21:38
@michaelbeaumont michaelbeaumont changed the title fix(gatewayapi): ListenerReason for unresolved certificate refs, enable ReferenceGrant conformance tests fix(gatewayapi): ListenerReason for unresolved certificate refs, enable ReferenceGrant conformance tests Aug 11, 2022
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) August 11, 2022 21:41
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) August 12, 2022 12:05
@michaelbeaumont michaelbeaumont merged commit 4a7b4d8 into kumahq:master Aug 12, 2022
@michaelbeaumont michaelbeaumont deleted the fix/gatewayapi_certref branch August 12, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants