Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): add listener connection limits #4755

Merged

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Aug 3, 2022

Checklist prior to review

The big line change is due to golden files updates

Adds

listeners:
  - ...
    resources:
      connectionLimit: 10000

to MeshGateway via Runtime Discovery Service (RTDS).

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #4755 (11389f9) into master (ecdf217) will increase coverage by 0.02%.
The diff coverage is 66.94%.

@@            Coverage Diff             @@
##           master    #4755      +/-   ##
==========================================
+ Coverage   46.42%   46.44%   +0.02%     
==========================================
  Files         690      690              
  Lines       46998    47086      +88     
==========================================
+ Hits        21817    21871      +54     
- Misses      23256    23290      +34     
  Partials     1925     1925              
Impacted Files Coverage Δ
api/mesh/v1alpha1/gateway.pb.go 6.85% <2.63%> (-0.90%) ⬇️
pkg/plugins/runtime/gateway/generator.go 84.16% <91.30%> (+1.31%) ⬆️
pkg/core/resources/apis/mesh/gateway_validator.go 88.19% <100.00%> (+1.27%) ⬆️
pkg/plugins/runtime/gateway/listener_generator.go 93.54% <100.00%> (+1.88%) ⬆️
pkg/xds/bootstrap/template_v3.go 96.17% <100.00%> (+0.14%) ⬆️
pkg/xds/generator/direct_access_proxy_generator.go 90.90% <0.00%> (+1.13%) ⬆️
pkg/core/resources/manager/cache.go 88.31% <0.00%> (+2.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@michaelbeaumont michaelbeaumont merged commit 5a5b18d into kumahq:master Aug 8, 2022
@michaelbeaumont michaelbeaumont deleted the feat/listener_connection_limits branch August 8, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gateway listener connection limit support xDS layered runtime support
3 participants