Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated Cluster.Http2ProtocolOptions #4528

Conversation

michaelbeaumont
Copy link
Contributor

Summary

Closes #2113

@michaelbeaumont michaelbeaumont force-pushed the chore/deprecated_http2_protocol_options branch from 167883e to bffc810 Compare June 30, 2022 10:51
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #4528 (bffc810) into master (177eedf) will decrease coverage by 0.02%.
The diff coverage is 82.85%.

@@            Coverage Diff             @@
##           master    #4528      +/-   ##
==========================================
- Coverage   55.49%   55.47%   -0.03%     
==========================================
  Files         946      946              
  Lines       58230    58235       +5     
==========================================
- Hits        32315    32306       -9     
- Misses      23374    23381       +7     
- Partials     2541     2548       +7     
Impacted Files Coverage Δ
pkg/xds/bootstrap/template_v3.go 97.31% <82.85%> (-2.01%) ⬇️
pkg/defaults/mesh.go 64.28% <0.00%> (-14.29%) ⬇️
pkg/metrics/store/counter.go 74.54% <0.00%> (-10.91%) ⬇️
pkg/defaults/components.go 85.71% <0.00%> (-3.58%) ⬇️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177eedf...bffc810. Read the comment docs.

@michaelbeaumont michaelbeaumont marked this pull request as ready for review June 30, 2022 11:44
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner June 30, 2022 11:44
@michaelbeaumont michaelbeaumont merged commit 9d5029e into kumahq:master Jun 30, 2022
@michaelbeaumont michaelbeaumont deleted the chore/deprecated_http2_protocol_options branch June 30, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated envoy.config.cluster.v3.Cluster.http2_protocol_options
3 participants