Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): memory store cannot delete a parent (backport #4194) #4196

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 19, 2022

This is an automatic backport of pull request #4194 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Signed-off-by: Jakub Dyszkiewicz <[email protected]>
(cherry picked from commit 8135fdb)
@mergify mergify bot requested a review from a team as a code owner April 19, 2022 13:50
@codecov-commenter
Copy link

Codecov Report

Merging #4196 (1a46939) into release-1.6 (653f198) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           release-1.6    #4196      +/-   ##
===============================================
+ Coverage        55.73%   55.77%   +0.03%     
===============================================
  Files              932      932              
  Lines            56230    56249      +19     
===============================================
+ Hits             31342    31371      +29     
+ Misses           22404    22399       -5     
+ Partials          2484     2479       -5     
Impacted Files Coverage Δ
pkg/plugins/resources/memory/store.go 78.80% <100.00%> (+1.08%) ⬆️
pkg/test/store/owner_test_template.go 100.00% <100.00%> (ø)
pkg/xds/cache/once/cache.go 87.17% <0.00%> (-7.70%) ⬇️
pkg/defaults/components.go 88.88% <0.00%> (+3.70%) ⬆️
pkg/kds/client/sink.go 59.45% <0.00%> (+5.40%) ⬆️
pkg/core/tokens/default_signing_key.go 72.22% <0.00%> (+5.55%) ⬆️
pkg/plugins/leader/postgres/leader_elector.go 100.00% <0.00%> (+6.38%) ⬆️
pkg/test/grpc/clientstream.go 92.00% <0.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653f198...1a46939. Read the comment docs.

@mergify mergify bot merged commit fe3d9c7 into release-1.6 Apr 19, 2022
@mergify mergify bot deleted the mergify/bp/release-1.6/pr-4194 branch April 19, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants