-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): allow specifying security context #4153
Conversation
Currently, there is no place to specify/customize the securityContext for following components: kuma-cp/ Jobs (crd/webhook/ns)/ Ingress / Egress / CNI This PR provides the option to specify securityContext for all of the above components. Co-authored-by: Gaurav Dasson <[email protected]> Co-authored-by: Bart Smykla <[email protected]> Signed-off-by: Gaurav Dasson <[email protected]> Signed-off-by: Bart Smykla <[email protected]>
…rity-contexts-to-helm
Codecov Report
@@ Coverage Diff @@
## master #4153 +/- ##
==========================================
+ Coverage 55.70% 55.72% +0.01%
==========================================
Files 932 932
Lines 56290 56290
==========================================
+ Hits 31355 31366 +11
+ Misses 22458 22440 -18
- Partials 2477 2484 +7
Continue to review full report at Codecov.
|
Signed-off-by: Bart Smykla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you retested with the new default LGTM!
Currently, there is no place to specify/customize the securityContext for following components: kuma-cp/ Jobs (crd/webhook/ns)/ Ingress / Egress / CNI This PR provides the option to specify securityContext for all of the above components. Co-authored-by: Gaurav Dasson <[email protected]> Co-authored-by: Bart Smykla <[email protected]> Signed-off-by: Gaurav Dasson <[email protected]> Signed-off-by: Bart Smykla <[email protected]> (cherry picked from commit d8208af)
Currently, there is no place to specify/customize the securityContext for following components: kuma-cp/ Jobs (crd/webhook/ns)/ Ingress / Egress / CNI This PR provides the option to specify securityContext for all of the above components. Co-authored-by: Gaurav Dasson <[email protected]> Co-authored-by: Bart Smykla <[email protected]> Signed-off-by: Gaurav Dasson <[email protected]> Signed-off-by: Bart Smykla <[email protected]> (cherry picked from commit d8208af) Co-authored-by: Bart Smykla <[email protected]>
@bartsmykla Good extension! Does your PR also offer the ability to specify a |
@johnharris85 I was not aware of this one. I'm eagerly awaiting #4241 then (well, I do have a work-around, about at the cost of granting elevated rights to the entire pod). |
I think this PR is missing the container security context for the kuma cni daemonset (which was included in the closed PR #4111). This PR only included the ability to specify pod security contexts. Should I open a new issue for this? |
Yes please do! |
Summary
Currently, there is no place to specify/customize
the securityContext for following components:
kuma-cp/ Jobs (crd/webhook/ns)/ Ingress / Egress / CNI
This PR provides the option to specify securityContext
for all of the above components.
cc. @gdasson @johnharris85
Full changelog
kuma-cp/ Jobs (crd/webhook/ns)/ Ingress / Egress / CNI
Issues resolved
Testing
Backwards compatibility
Does not affect backward compatibility