Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): Gateway API behind experimental flag #4014

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Mar 18, 2022

Summary

Gateway API behind a config flag.

Issues resolved

xref #3702

Documentation

Docs are in progress for the whole feature.

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

- [ ] Update UPGRADE.md with any steps users will need to take when upgrading.
- [ ] Add backport-to-stable label if the code follows our backporting policy

Changelog: feat(gateway): release K8s GatewayAPI as preview

@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner March 18, 2022 09:13
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didn't we also talk about not having gatewayAPI if in multizone?

@jakubdyszkiewicz
Copy link
Contributor Author

It's a separate issue #3905

We could do validation on the config (if experimental gateway enabled && mode != standalone then fail), but at some point we will drop the flag and this validation should work anyways, so we need a hook for it.

@jakubdyszkiewicz jakubdyszkiewicz merged commit 7f07cf0 into master Mar 18, 2022
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/gateway-api-feature-flag branch March 18, 2022 13:21
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Mar 30, 2022
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Apr 14, 2022
SallyBlichWalkMe pushed a commit to SallyBlichWalkMe/kuma that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants