Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s): reenable deep copies when interacting with k8s resources #10561

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jun 19, 2024

Closes #8160

This was enabled in some form in #1113 and then in its current form in #6809

This is of course more correct but the performance implications are not 100% clear.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner June 19, 2024 12:17
@michaelbeaumont michaelbeaumont requested review from jijiechen and bartsmykla and removed request for a team June 19, 2024 12:17
@michaelbeaumont michaelbeaumont added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Jun 19, 2024
@michaelbeaumont michaelbeaumont changed the base branch from release-2.8 to master June 20, 2024 09:32
Signed-off-by: Mike Beaumont <[email protected]>
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it and check the result of mesh-perf

@michaelbeaumont michaelbeaumont merged commit 376d824 into kumahq:master Jul 3, 2024
35 checks passed
@michaelbeaumont michaelbeaumont deleted the fix/k8s-deep-copies branch July 3, 2024 10:58
@jijiechen jijiechen changed the title fix(k8s): reenable deep copies fix(k8s): reenable deep copies when interacting with k8s resources Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

concurrent map read and map write in k8s controllers
4 participants