Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading with helm from 2.0.1 to 2.1.1 doesn’t work because the CRDs do not get updated #6201

Closed
slonka opened this issue Mar 6, 2023 · 3 comments · Fixed by #6403
Closed
Labels
kind/bug A bug triage/pending This issue will be looked at on the next triage meeting

Comments

@slonka
Copy link
Contributor

slonka commented Mar 6, 2023

What happened?

Reported via internal slack by @doctorwu.

@slonka slonka added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Mar 6, 2023
@jakubdyszkiewicz jakubdyszkiewicz added triage/needs-reproducing Someone else should try to reproduce this and removed triage/pending This issue will be looked at on the next triage meeting labels Mar 6, 2023
@jakubdyszkiewicz jakubdyszkiewicz added triage/pending This issue will be looked at on the next triage meeting and removed triage/needs-reproducing Someone else should try to reproduce this labels Mar 29, 2023
@jakubdyszkiewicz
Copy link
Contributor

I confirm the issue. MeshTrafficPermission CRD is not updated. After upgrade you can still see

$ kubectl get crd meshtrafficpermissions.kuma.io -oyaml | grep -i allow
                          - ALLOW
                          - ALLOW_WITH_SHADOW_DENY

instead of

$ kubectl get crd meshtrafficpermissions.kuma.io -oyaml | grep -i allow
                          - Allow
                          - AllowWithShadowDeny

@michaelbeaumont
Copy link
Contributor

Sounds like kumactl install crds --only-missing isn't doing the right thing here? IIRC I think we have to use that Job because /crds in Helm doesn't support upgrades.

@jakubdyszkiewicz
Copy link
Contributor

Yes. I'm testing if this kind of upgrade is even possible, and it seems it is.
I think we can just get rid of this --only-missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug triage/pending This issue will be looked at on the next triage meeting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants