Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policy generator to generate validate() with sub-functions #5005

Closed
slonka opened this issue Sep 14, 2022 · 0 comments · Fixed by #5014
Closed

Policy generator to generate validate() with sub-functions #5005

slonka opened this issue Sep 14, 2022 · 0 comments · Fixed by #5014
Labels
kind/improvement Improvement on an existing feature triage/pending This issue will be looked at on the next triage meeting

Comments

@slonka
Copy link
Contributor

slonka commented Sep 14, 2022

Description

Coming from this comment: #4998 (comment)
@slonka slonka added triage/pending This issue will be looked at on the next triage meeting kind/improvement Improvement on an existing feature labels Sep 14, 2022
@slonka slonka mentioned this issue Sep 14, 2022
Merged
12 tasks
lahabana added a commit to lahabana/kuma that referenced this issue Sep 15, 2022
@lahabana
chore(bootstrap): improve validator policy bootstrap
21af312 
- Use validators.ValidationError{} more nicely to avoid passing parameters
- Update bootstrap template to split validation in 3 methods
- Update already generated policies to this new pattern

Fix kumahq#5005

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana mentioned this issue Sep 15, 2022
Merged
12 tasks
lahabana added a commit that referenced this issue Sep 20, 2022
@lahabana
chore(bootstrap): improve validator policy bootstrap (#5014)
b45096d 
- Use validators.ValidationError{} more nicely to avoid passing parameters
- Update bootstrap template to split validation in 3 methods
- Update already generated policies to this new pattern

Fix #5005

Signed-off-by: Charly Molter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement Improvement on an existing feature triage/pending This issue will be looked at on the next triage meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(bootstrap): improve validator policy bootstrap lahabana/kuma
1 participant
@slonka