Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the kuma RetryPolicy with few more options which envoy supports already #4494

Closed
pranavkevadiya opened this issue Jun 22, 2022 · 1 comment · Fixed by #4669 or #4744
Closed
Assignees
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@pranavkevadiya
Copy link

pranavkevadiya commented Jun 22, 2022

Description

Source code:
https://github.com/kumahq/kuma/blob/master/pkg/xds/envoy/listeners/v3/retry_configurer.go#L18

The code above sets the RetryPolicy field retry_on as
connect-failure,refused-stream,retriable-status-codes
These values however don't include retrying for a socket timeout or a closed connection. We have encountered such failures in our integration testing and we think a retry would have helped.

As per our analysis, if Kuma supports either of the following retry_on values to be propagated to the underlying envoy configuration, it should solve our purpose.

- reset
- connect-failure
- refused-stream
- http3-post-connect-failure
- retriable-status-codes

OR

- 5xx
- http3-post-connect-failure
- retriable-status-codes

Envoy configuration options for retry_on:
https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/router_filter#x-envoy-retry-on

@pranavkevadiya pranavkevadiya added kind/feature New feature triage/pending This issue will be looked at on the next triage meeting labels Jun 22, 2022
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jul 4, 2022
@johnharris85 johnharris85 reopened this Jul 26, 2022
@johnharris85
Copy link
Contributor

Was closed accidentally by merging the MADR, re-opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
3 participants