KDS Reconciles all DP related insights

[lahabana]

What happened?

I think something is wrong with reconciliation of insights. At the beginning I thought it's only related to Zone{In,E}gressInsights, but it looks like it's for all dataplane related insights.
I went to the doctor and forget to stop my CPs and have a lot of updates (every 2.5 minutes).

This shouldn't happen if no change happen on the cluster

[parkanzky]

These inherit from DataplaneInsights, which has the field -

  // Generation is an integer number which is periodically increased by the
  // status sink
  uint32 generation = 7;

Logging the objects it is evident that this is, indeed, increasing on every sync and appears in the GetSpec() output we compare to decide whether a change occurred.

May need to handle this differently.

[lahabana]

Ho this was introduced with: #2526 which makes sense... Should we remove the generation in the KDS code to avoid syncing things that do not really matter outside of the local zone?
@jakubdyszkiewicz @lobkovilya WDYT?

[lahabana]

Maybe there's something to be done with the ResourceMapper to strip this info?