Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Zipkin shared_span_context Configuration #1656

Closed
ericmustin opened this issue Mar 10, 2021 · 3 comments · Fixed by #1660
Closed

add Zipkin shared_span_context Configuration #1656

ericmustin opened this issue Mar 10, 2021 · 3 comments · Fixed by #1660

Comments

@ericmustin
Copy link
Contributor

Summary

👋 Hello, would y'all take a PR to add support for configuring shared_span_context on the zipkin tracing configuration?

zipkinConfig := envoy_trace.ZipkinConfig{
CollectorCluster: names.GetTracingClusterName(backendName),
CollectorEndpoint: url.Path,
TraceId_128Bit: cfg.TraceId128Bit,
CollectorEndpointVersion: apiVersion(&cfg, url),
}

This config option, which controls whether to reuse span_id for both client and server spans (a concept largely unique to zipkin), causes some users to experience issues downstream in Opentelemetry, so having the configurability would be super helpful. for context:

@jakubdyszkiewicz
Copy link
Contributor

Hey @ericmustin

Sounds reasonable to add it, feel free to send a PR!

@ericmustin
Copy link
Contributor Author

@jakubdyszkiewicz pushed up a pr, lmk what u think

@ericmustin
Copy link
Contributor Author

ericmustin commented Mar 15, 2021

just chiming in to say i tested the latest release (1.1.1) which contains the linked pr here and this does work as expected:

And now look, some nice, connected distributed traces of kong/kuma/envoy/nodejs in zipkin+opentelemetry, being displayed in datadog :)

Image 2021-03-15 at 4 26 56 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants