Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle listener warming #1012

Closed
jakubdyszkiewicz opened this issue Sep 8, 2020 · 0 comments · Fixed by #1098
Closed

Handle listener warming #1012

jakubdyszkiewicz opened this issue Sep 8, 2020 · 0 comments · Fixed by #1098

Comments

@jakubdyszkiewicz
Copy link
Contributor

Summary

https://www.envoyproxy.io/docs/envoy/latest/api-docs/xds_protocol#resource-warming

In the first version of Kuma 0.1. We had a problem with cluster warming. We fixed it with a custom implementation of the server https://github.com/kumahq/kuma/blob/master/pkg/xds/server/server.go#L302

A more elegant way without "forking" the server is to force a new version of the EDS when CDS changes. This way we can get rid of this code.

Additionally, we don't handle listener warming. We should send RDS change when we LDS changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant